Skip to content

Update expected swift-testing failure message#2157

Merged
award999 merged 7 commits into
swiftlang:mainfrom
award999:main-test-failures
Mar 17, 2026
Merged

Update expected swift-testing failure message#2157
award999 merged 7 commits into
swiftlang:mainfrom
award999:main-test-failures

Conversation

@award999
Copy link
Copy Markdown
Contributor

@award999 award999 commented Mar 16, 2026 •
edited
Loading

Description

Looks like the expected format of the main toolchain's failure message has changed

+ expected - actual

       "test": "PackageTests.MixedSwiftTestingSuite"
     }
     {
       "issues": [
-        "testFailing() › Expectation failed: 1 == 2\n1 == 2 → false"
+        "testFailing() › Expectation failed: 1 == 2"
       ]
       "test": "PackageTests.MixedSwiftTestingSuite/testFailing()"
     }
   ]

Update: no windows build for this so just going to assert on the first line for now

Issue: N/A

Tasks

  • Required tests have been written
  • [ ] Documentation has been updated
  • [ ] Added an entry to CHANGELOG.md if applicable

@award999 award999 requested a review from adam-fowler as a code owner March 16, 2026 13:57
@award999 award999 added the full-test-run Perform a full test suite run. Apply this label before pushing up a PR or commit label Mar 16, 2026
@award999 award999 requested a review from 0xTim as a code owner March 16, 2026 13:57
@award999 award999 merged commit 51b82a0 into swiftlang:main Mar 17, 2026
29 checks passed
@award999 award999 deleted the main-test-failures branch March 17, 2026 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rbenegal rbenegal rbenegal approved these changes

@adam-fowler adam-fowler Awaiting requested review from adam-fowler adam-fowler is a code owner

@0xTim 0xTim Awaiting requested review from 0xTim 0xTim is a code owner

Assignees

No one assigned

Labels

full-test-run Perform a full test suite run. Apply this label before pushing up a PR or commit

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@award999 @rbenegal